Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: standalone docker mode (draft only) #182

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

puehringer
Copy link
Contributor

@puehringer puehringer commented Feb 16, 2024

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

  • Showcase of a standalone Docker mode for any visyn_* application. This even works with a single Docker image as we can serve the bundle directly from FastAPI. This works by simply pushing the backend (+ frontend bundle) as Docker image to GHCR.
  • Notes
    • this is not using our secure base images (which are private), such that the image is larger and less secure as the hardened version. Building images via our normal CI/CD pipeline will use secure images.
    • this is not using our CI/CD pipelines as defined in github-workflows. In the future, we might want to take the reusable bits and move them there.

Screenshots

image

Additional notes for the reviewer(s)

To test, simply run docker compose -f ./deploy/standalone/docker-compose.yml up and you should see the application running at http://localhost:9000/.

Thanks for creating this pull request 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant